Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common prepositions to titleCaseNotCapitalized #156

Closed
wants to merge 1 commit into from
Closed

Add common prepositions to titleCaseNotCapitalized #156

wants to merge 1 commit into from

Conversation

HatScripts
Copy link
Contributor

@HatScripts HatScripts commented Oct 9, 2023 •
edited
Loading

  • I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

To test this pull request, follow the instructions in the wiki.

Added some common prepositions that were missing in the titleCaseNotCapitalized set:

  • with
  • from
  • into
  • onto

@ajayyy
Copy link
Owner

ajayyy commented Oct 9, 2023 •
edited
Loading

I actually just removed thesea few days ago. According to APA, they don't count

For reference 4e12428 0c74a2a

@HatScripts
Copy link
Contributor Author

HatScripts commented Oct 11, 2023 •
edited
Loading

APA might say they don't count, but pretty much all the major websites have these words as lowercase in titles:

Screenshot 2023-10-11 173334 Screenshot 2023-10-11 173440 Screenshot 2023-10-11 173408 Screenshot 2023-10-11 173606 Screenshot 2023-10-11 173658 Screenshot 2023-10-11 173628 Screenshot 2023-10-11 173856 Screenshot 2023-10-11 173929 Screenshot 2023-10-11 173913

Further reading:

@ajayyy
Copy link
Owner

ajayyy commented Oct 23, 2023

Added them back, thanks 304c926

@ajayyy ajayyy closed this Oct 23, 2023
@HatScripts HatScripts deleted the patch-1 branch October 24, 2023 04:05
@HatScripts
Copy link
Contributor Author

If I were you I would remove "over" and "like" as it's common for these to be used as adjectives, verbs, etc.

ajayyy added a commit that referenced this pull request Oct 25, 2023
@ajayyy
Remove over and list from lower case words in title case
77c31e8 
#156
@ajayyy
Copy link
Owner

ajayyy commented Oct 25, 2023

Good idea, did in 77c31e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HatScripts @ajayyy